Repository navigation
Register browser even if get url fails. - #263
Merged
Merged
Conversation
An issue was reported with SeleniumLibrary [1] where if "Open Browser" succeeds in starting the browser but the get url call fails the opened browser doesn't get registered with the Library's internal browser registery. Thus when 'Close All Browsers' is called it fails to close the opened browser. This patch fixes that problem. [1] http://code.google.com/p/robotframework-seleniumlibrary/issues/detail?id=220
This patch verifies the fix for robotframework#70.
Contributor
|
Looks good to me |
ombre42
added a commit
that referenced
this pull request
Jan 24, 2014
Register browser even if get url fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test and patch for fixing issue #70.